[Freeipa-devel] [PATCH] 420 Regression fix: rule table with ext. member support doesn't offer any items

[Petr Vobornik]

On 06/13/2013 05:13 PM, Ana Krivokapic wrote:
> On 06/13/2013 03:24 PM, Petr Vobornik wrote:
>> On 06/13/2013 02:46 PM, Ana Krivokapic wrote:
>>> On 06/13/2013 12:30 PM, Petr Vobornik wrote:
>>>> Rule tables with external member has more than one column and
>>>> therefore exclude parameter for adder dialog is not array of strings
>>>> but array of objects. normalize_values function can't work with it and
>>>> causes JS error.
>>>>
>>>> This patch creates proper exclude array before passing it to adder
>>>> dialog.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/3711
>>
>>> ACK
>>>
>>
>> I've noticed that there is a leftover from a different approach:
>>
>>              pkey: pkey,
>> +            param: that.name,
>>              other_entity: that.other_entity,
>>
>> The line is removed, updated patch attached.
>>
>
> I missed it too in the first patch. ACK for updated patch.


pushed to master, ipa-3-2.

>
> --
> Regards,
>
> Ana Krivokapic
> Associate Software Engineer
> FreeIPA team
> Red Hat Inc.

-- 
Petr Vobornik