[Freeipa-devel] [PATCHES] 0227-0229 freeipa-tests package & Beaker integration plugin

[Petr Viktorin]

On 06/14/2013 03:20 PM, Jan Cholasta wrote:
> Hi,
>
> On 28.5.2013 17:55, Petr Viktorin wrote:
>> Hello,
>>
>> Patch 0227 creates the freeipa-tests package.
>> As a system package, it needs a more unique name than "tests", so I
>> renamed it to "ipatests". I also changed imports and references to it.
>> Sorry to everyone developing tests right now ­– there will be conflicts,
>> but hopefully they'll be straightforward.
>> Note that the test suite does not yet pass when run outside the Git
>> tree. Work on that is ongoing but not a priority right now (it's more
>> important to get some integration tests running). Help would be
>> appreciated :)
>
> Typo in commit message: "Tename the 'tests' directory ..."

Thanks for the catch!

> The patch needs rebasing.

Attaching rebased versions.

>> Patch 0228 adds a wrapper based on make-test which runs the
>> system-installed test suite. freeipa-tests installs it as
>> /usr/bin/ipa-run-tests.
>> As I said above the tests currently fail when run this way.
>>
>> Patch 0229 adds a Nose plugin for integration with BeakerLib[1]. When
>> the plugin is loaded (ipa-run-tests does that) and enabled (using the
>> --with-beakerlib option), it hooks into Nose and runs rlPhase*, rlPass,
>> rlFail and rlLog* Bash functions at appropriate events.
>>
>
> I still need to actually run the code, I will do that with your patches
> 230-240 included.

If I may suggest, please test this set by itself. The tests→ipatests 
rename blocks or conflicts with other patches so it would be good to get 
it in soon, without waiting on the integration testing review.


-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0227.2-Make-an-ipa-tests-package.patch
Type: text/x-patch
Size: 71201 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130614/162832b0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0228.2-Add-ipa-run-tests-command.patch
Type: text/x-patch
Size: 2517 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130614/162832b0/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0229.2-Add-Nose-plugin-for-BeakerLib-integration.patch
Type: text/x-patch
Size: 11056 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130614/162832b0/attachment-0002.bin>