[Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

[Tomas Babej]

On 06/20/2013 12:52 PM, Jan Cholasta wrote:
> On 20.6.2013 12:28, Tomas Babej wrote:
>> Providing new version:
>>    - no longer requires root access defaultly
>>    - headers are printed out as comments
>>
>> Tomas
>>
>
> You still have reference(s) to previous names of the script in the patch:
>
> +    """
> +    Base class for advices, plugins for ipa-config-advice.
> +    """
>
Fixed.

> Is the --list option absolutely necessary? If I read your code 
> correctly, the list of advices is also returned when you run 
> ipa-advise without arguments.
>
> Honza
>

New version:
   - provides require_root setting for plugins
   - options --list removed, man pages altered accordingly

I'm also thinking about propagating the --verbose, etc. options provided 
by default by AdminTool down to plugin level so that plugin authors can
make use of them. What do you think?

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0072-4-Provide-ipa-advise-tool.patch
Type: text/x-patch
Size: 19127 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130621/5e48b08d/attachment.bin>