[Freeipa-devel] [PATCH] 421 Fix default value selection in radio widget

[Petr Vobornik]

On 06/24/2013 04:01 PM, Ana Krivokapic wrote:
> On 06/24/2013 12:42 PM, Petr Vobornik wrote:
>> On 06/20/2013 06:11 PM, Ana Krivokapic wrote:
>>> On 06/18/2013 07:28 PM, Petr Vobornik wrote:
>>>> Fix default value selection in radio widget
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/3718>>
>>>
>>> The web UI now displays 'Forward policy' as 'Forward first' when no
>>> policy is active (e.g. in case of empty Global DNS Configuration). Do we
>>> really want to have a default value for this particular radio button?
>>> Shouldn't it be unselected as default?
>>>
>>> --
>>> Regards,
>>>
>>> Ana Krivokapic
>>
>> IMO checking 'Forward first' when value is missing is correct. 'Forward first'
>> is default in BIND so It tells admin what is the effective value and therefore
>> admin doesn't have to remember what are the defaults.
>
> OK, that makes sense.
>
>>
>> There is one case when it would make sense to leave it unchecked. That is when
>> no Global forwarder is set. 'Forward policy' is not used in that case.
>
> So in that case 'Forward policy' should be disabled. In other words, it should
> only be enabled when 'Global forwarders' is not empty.
>

I've discussed it with Ana in person and we've agreed on that the 
current approach is sufficient (ACK).

Pushed to master, ipa-3-2.
-- 
Petr Vobornik