[Freeipa-devel] [PATCH] 0007 Web UI: Realm Domains page

[Ana Krivokapic]

On 03/06/2013 10:40 AM, Petr Vobornik wrote:
> On 03/05/2013 05:52 PM, Ana Krivokapic wrote:
>> On 02/27/2013 05:10 PM, Petr Vobornik wrote:
>>> On 02/27/2013 04:20 PM, Ana Krivokapic wrote:
>>>> Add support for Realm Domains to web UI.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/3407
>>>
>>> The patch looks good, but there is a issue we don't have a precedence
>>> for.
>>>
>>> The mod command is doing dns check for new domains. Currently we can't
>>> specify --force option to bypass the check.
>>>
>>> I see two possible implementations:
>>> 1) On update, when user adds or modifies the values, a dialog would
>>> pop up and ask user whether he wants to force it.
>>>
>>> 2) Another option is to disable edit on the list(deletion would be
>>> still allowed) and move the add operation to separate action in action
>>> list.
>>>
>>> I prefer the former. Latter might have issues with two modifications
>>> (delete and add) at the same time at two different places (facet and
>>> add dialog).
>>
>> Added force option to the error dialog.
>>
>> Updated patch is attached.
>>
>
> 1) I think the dialog with the force should be shown before executing
> the operation. Sometimes, DNS check can take several seconds. There is
> no point for waiting for the error if you know that it will fail.
>
> 2) Regardless of #1. I don't think that just adding 'force' button
> without explaining the user what it means is the way to go.
>
> Previously (solution #1) I had in mind to show following dialog after
> clicking on 'update':
>
>
> -------------------------------------------------------
> [Check DNS]
> -------------------------------------------------------
>
> Do you also want to perform DNS check?
>
>                             [Check DNS] [Force Update]
> -------------------------------------------------------
>
> Default button (confirm button) will be [Check DNS]
>

Thanks, fixed, and I also added a Cancel button, in case the user wants
to back out.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0007-03-Realm-Domains-page.patch
Type: text/x-patch
Size: 10046 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130306/e9a411a8/attachment.bin>