[Freeipa-devel] [PATCH 0149] Clean up PTR record synchronization code and make it more robust

Tomas Babej tbabej at redhat.com
Tue May 14 14:41:27 UTC 2013


On 05/13/2013 05:22 PM, Petr Spacek wrote:
> On 13.5.2013 16:49, Simo Sorce wrote:
>> On Mon, 2013-05-13 at 16:32 +0200, Petr Spacek wrote:
>>> +       if ((ip = inet_addr(ip_str)) == INADDR_NONE) {
>>
>>
>> This kind of construct is hard to read and debug in gdb
>> I would suggest you do:
>> ip = inet_addr(ip_str);
>> if (ip == INADDER_NONE) {
>
> I agree, done.
>
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
I tested the patch, works fine. ACK

Tomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130514/ef58a1f9/attachment.htm>


More information about the Freeipa-devel mailing list