[Freeipa-devel] [PATCH 0125] ipatests: Add which package to legacy client advice

[Petr Viktorin]

On 11/01/2013 03:34 PM, Ana Krivokapic wrote:
> On 11/01/2013 03:30 PM, Tomas Babej wrote:
>> On 11/01/2013 03:27 PM, Ana Krivokapic wrote:
>>> On 11/01/2013 03:18 PM, Tomas Babej wrote:
>>>> On 10/31/2013 12:10 PM, Ana Krivokapic wrote:
>>>>> On 10/30/2013 04:18 PM, Tomas Babej wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Adds which package to the requirements, since older distros do not
>>>>>> have it by default.
>>>>>>
>>>>>> Part of: https://fedorahosted.org/freeipa/ticket/3833
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Freeipa-devel mailing list
>>>>>> Freeipa-devel at redhat.com
>>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>>>
>>>>> You can use the bash built-in command `command`, instead of
>>>>> `which`, to find out if a program exists:
>>>>>
>>>>> command -v cacertdir_rehash
>>>>>
>>>>> In other words, just replace `which` with `command -v`; there's no
>>>>> need to install any additional packages.
>>>>> --
>>>>> Regards,
>>>>>
>>>>> Ana Krivokapic
>>>>> Associate Software Engineer
>>>>> FreeIPA team
>>>>> Red Hat Inc.
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Freeipa-devel mailing list
>>>>> Freeipa-devel at redhat.com
>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>>
>>>> Thanks!
>>>>
>>>> Updated patch attached.
>>>>
>>>>
>>>>
>>>> --
>>>> Tomas Babej
>>>> Associate Software Engeneer | Red Hat | Identity Management
>>>> RHCE | Brno Site | IRC: tbabej | freeipa.org
>>>
>>> Looks good! Please just amend the commit message to reflect the new
>>> content of the patch.
>>>
>>> --
>>> Regards,
>>>
>>> Ana Krivokapic
>>> Associate Software Engineer
>>> FreeIPA team
>>> Red Hat Inc.
>>
>> Good catch. Fixed.
>>
>> --
>> Tomas Babej
>> Associate Software Engeneer | Red Hat | Identity Management
>> RHCE | Brno Site | IRC: tbabej | freeipa.org
>
> ACK

Pushed to:
master: 00c0878b90f0fbbe33f90cad145fefffdaaaa4aa
ipa-3-3: 33ea1496572aa2f8545b853cc2b3bb4e3d5cc967

-- 
Petr³