[Freeipa-devel] [PATCH 0024] Add OTP support to ipalib CLI

[Nathaniel McCallum]

On Wed, 2013-10-30 at 08:57 +0100, Jan Cholasta wrote:
> On 8.10.2013 16:35, Nathaniel McCallum wrote:
> > On Tue, 2013-10-08 at 09:19 +0200, Jan Cholasta wrote:
> >>
> >> +class Base32DecodeError(ExecutionError):
> >>
> >> Is this really necessary? Are we going to add <encoding>DecodeError for
> >> every kind of new encoding in IPA? Can't we just have generic
> >> DecodeError? (This is not an issue in your patch per se, I'm just
> >> wondering if we can do it better in the framework.)
> >
> > I added the new error due to the existence of a Base64DecodeError. I
> > figured changing the existing error to be more generic would break api.
> >
> > Nathaniel
> >
> 
> I think you can use ConversionError instead. I don't see any reason why 
> base32/64 decoding errors should be special cased like this and would 
> like to see Base64DecodeError gone.

Fixed.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-npmccallum-0024-3-Add-OTP-support-to-ipalib-CLI.patch
Type: text/x-patch
Size: 29234 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20131114/86533959/attachment.bin>