[Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

Petr Vobornik pvoborni at redhat.com
Fri Nov 15 14:28:51 UTC 2013


On 11/15/2013 02:40 PM, Petr Viktorin wrote:
> On 11/15/2013 02:26 PM, Petr Vobornik wrote:
>> Hello list,
>>
>> this is a first part of RCUE adoption effort. Main themes of this patch
>> set are:
>>
>> - use RCUE navigation <https://fedorahosted.org/freeipa/ticket/3902>
>> - new styles for textboxes, textareas, radio/checkbox buttons and
>> buttons- part of <https://fedorahosted.org/freeipa/ticket/3904>
>> - new internal form layout (tables replaced by divs)
>> - layout does not have fixed size
>> <https://fedorahosted.org/freeipa/ticket/3435>
>> - new dialog styles + removed dependency on jQuery UI dialog
>> - icons replaced by Font Awesome glyphs
>>
>> Example is at: <http://pvoborni.fedorapeople.org/rcue/>
>>
>> Some reasonings and additional info:
>>
>> 1. RCUE includes Bootstrap which defines o lot of styles for a lot of
>> things. That messed up the UI and therefore I did the form changes now.
>>
>> 2. jQuery UI is pretty big lib and we used it only for dialog and
>> buttons. Buttons were replaced by RCUE buttons so removal of dialog
>> dependency was a obvious step to get rid of the whole lib. The lib is
>> removed from main UI but is still present in separate pages - will be
>> removed later.
>>
>> 3. Dojo and jQuery were upgraded to latest
>> versions.<https://fedorahosted.org/freeipa/ticket/2811>
>>
>> This approach was ACKed by Kyle from a design perspective with a note
>> that we will review and fixed some styling after second phase. We should
>> not release until then.
>>
>> The second phase, which I'm working on right now, will consist of:
>>   * login screen <https://fedorahosted.org/freeipa/ticket/3903>
>>   * new styles for standalone pages
>>   * necessary responsive enhancement (the ultimate future goal is
>> responsive layout)
>>
>> It's quite a lot of patches so I did not attach them here. You can see
>> the code in my private repo:
>> <git://fedorapeople.org/~pvoborni/freeipa.git> branch 'rcue'.
>
> Wow. Do we really need all these third-party fonts and styles in our repo?

It's common in Web development to offer all versions and let the browser 
to choose one.

Since FreeIPA Web UI supports IE9+ we can safely reduce the font files 
only to .woff fonts <http://caniuse.com/woff>. We can also discard all 
Italic fonts (not used atm).

Fedora 20 has a new feature called Web Assets 
<http://fedoraproject.org/wiki/Changes/Web_Assets> which should solve 
such bundles. I'm not convinced that it's in usable state atm.

>
>
>   install/ui/font/FontAwesome.otf                       | Bin 0 -> 62856
> bytes
>   install/ui/font/Makefile.am                           |  45 +++++++++++
>   install/ui/font/OpenSans-Bold-webfont.eot             | Bin 0 -> 21190
> bytes
>   install/ui/font/OpenSans-Bold-webfont.svg             | 146
> ++++++++++++++++++++++++++++++++++
>   install/ui/font/OpenSans-Bold-webfont.ttf             | Bin 0 -> 21012
> bytes
>   install/ui/font/OpenSans-Bold-webfont.woff            | Bin 0 -> 14036
> bytes
>   install/ui/font/OpenSans-BoldItalic-webfont.eot       | Bin 0 -> 23510
> bytes
>   install/ui/font/OpenSans-BoldItalic-webfont.svg       | 146
> ++++++++++++++++++++++++++++++++++
>   install/ui/font/OpenSans-BoldItalic-webfont.ttf       | Bin 0 -> 23304
> bytes
>   install/ui/font/OpenSans-BoldItalic-webfont.woff      | Bin 0 -> 15572
> bytes
>   install/ui/font/OpenSans-ExtraBold-webfont.eot        | Bin 0 -> 21186
> bytes
>   install/ui/font/OpenSans-ExtraBold-webfont.svg        | 146
> ++++++++++++++++++++++++++++++++++
>   install/ui/font/OpenSans-ExtraBold-webfont.ttf        | Bin 0 -> 20988
> bytes
>   install/ui/font/OpenSans-ExtraBold-webfont.woff       | Bin 0 -> 14200
> bytes
>   install/ui/font/OpenSans-ExtraBoldItalic-webfont.eot  | Bin 0 -> 23086
> bytes
>   install/ui/font/OpenSans-ExtraBoldItalic-webfont.svg  | 146
> ++++++++++++++++++++++++++++++++++
>   install/ui/font/OpenSans-ExtraBoldItalic-webfont.ttf  | Bin 0 -> 22860
> bytes
>   install/ui/font/OpenSans-ExtraBoldItalic-webfont.woff | Bin 0 -> 15468
> bytes
>   install/ui/font/OpenSans-Italic-webfont.eot           | Bin 0 -> 23866
> bytes
>   install/ui/font/OpenSans-Italic-webfont.svg           | 146
> ++++++++++++++++++++++++++++++++++
>   install/ui/font/OpenSans-Italic-webfont.ttf           | Bin 0 -> 23680
> bytes
>   install/ui/font/OpenSans-Italic-webfont.woff          | Bin 0 -> 15836
> bytes
>   install/ui/font/OpenSans-Light-webfont.eot            | Bin 0 -> 20886
> bytes
>   install/ui/font/OpenSans-Light-webfont.svg            | 146
> ++++++++++++++++++++++++++++++++++
>   install/ui/font/OpenSans-Light-webfont.ttf            | Bin 0 -> 20704
> bytes
>   install/ui/font/OpenSans-Light-webfont.woff           | Bin 0 -> 13972
> bytes
>   install/ui/font/OpenSans-LightItalic-webfont.eot      | Bin 0 -> 24074
> bytes
>   install/ui/font/OpenSans-LightItalic-webfont.svg      | 146
> ++++++++++++++++++++++++++++++++++
>   install/ui/font/OpenSans-LightItalic-webfont.ttf      | Bin 0 -> 23864
> bytes
>   install/ui/font/OpenSans-LightItalic-webfont.woff     | Bin 0 -> 15944
> bytes
>   install/ui/font/OpenSans-Regular-webfont.eot          | Bin 0 -> 20878
> bytes
>   install/ui/font/OpenSans-Regular-webfont.svg          | 146
> ++++++++++++++++++++++++++++++++++
>   install/ui/font/OpenSans-Regular-webfont.ttf          | Bin 0 -> 20688
> bytes
>   install/ui/font/OpenSans-Regular-webfont.woff         | Bin 0 -> 13988
> bytes
>   install/ui/font/OpenSans-Semibold-webfont.eot         | Bin 0 -> 21046
> bytes
>   install/ui/font/OpenSans-Semibold-webfont.svg         | 146
> ++++++++++++++++++++++++++++++++++
>   install/ui/font/OpenSans-Semibold-webfont.ttf         | Bin 0 -> 20852
> bytes
>   install/ui/font/OpenSans-Semibold-webfont.woff        | Bin 0 -> 14052
> bytes
>   install/ui/font/OpenSans-SemiboldItalic-webfont.eot   | Bin 0 -> 23882
> bytes
>   install/ui/font/OpenSans-SemiboldItalic-webfont.svg   | 146
> ++++++++++++++++++++++++++++++++++
>   install/ui/font/OpenSans-SemiboldItalic-webfont.ttf   | Bin 0 -> 23660
> bytes
>   install/ui/font/OpenSans-SemiboldItalic-webfont.woff  | Bin 0 -> 15748
> bytes
>   install/ui/font/Overpass-Bold-webfont.eot             | Bin 0 -> 35037
> bytes
>   install/ui/font/Overpass-Bold-webfont.svg             | 454
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
>   install/ui/font/Overpass-Bold-webfont.ttf             | Bin 0 -> 69020
> bytes
>   install/ui/font/Overpass-Bold-webfont.woff            | Bin 0 -> 40664
> bytes
>   install/ui/font/Overpass-Regular-webfont.eot          | Bin 0 -> 33709
> bytes
>   install/ui/font/Overpass-Regular-webfont.svg          | 454
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
>   install/ui/font/Overpass-Regular-webfont.ttf          | Bin 0 -> 67172
> bytes
>   install/ui/font/Overpass-Regular-webfont.woff         | Bin 0 -> 38948
> bytes
>   install/ui/font/fontawesome-webfont.eot               | Bin 0 -> 38205
> bytes
>   install/ui/font/fontawesome-webfont.svg               | 414
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
>   install/ui/font/fontawesome-webfont.ttf               | Bin 0 -> 80652
> bytes
>   install/ui/font/fontawesome-webfont.woff              | Bin 0 -> 44432
> bytes
>   install/ui/images/Makefile.am                         |   8 +-
>   install/ui/images/background-center.png               | Bin 2839 -> 0
> bytes
>   install/ui/images/background-left.png                 | Bin 3193 -> 0
> bytes
>   install/ui/images/background-right.png                | Bin 3211 -> 0
> bytes
>   install/ui/images/header-logo.png                     | Bin 0 -> 2539
> bytes
>   install/ui/images/mainnav-background.png              | Bin 34917 -> 0
> bytes
>   install/ui/images/spinner-header-1.gif                | Bin 0 -> 9427
> bytes
>   install/ui/images/spinner-header.gif                  | Bin 2841 -> 0
> bytes
>   install/ui/images/top-background.png                  | Bin 7883 -> 0
> bytes
>   install/ui/less/font-awesome/bordered-pulled.less     |  17 ++++
>   install/ui/less/font-awesome/core.less                |  12 +++
>   install/ui/less/font-awesome/fixed-width.less         |   6 ++
>   install/ui/less/font-awesome/font-awesome.less        |  17 ++++
>   install/ui/less/font-awesome/icons.less               | 412
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
>   install/ui/less/font-awesome/larger.less              |  13 ++++
>   install/ui/less/font-awesome/list.less                |  23 ++++++
>   install/ui/less/font-awesome/mixins.less              |  18 +++++
>   install/ui/less/font-awesome/path.less                |  14 ++++
>   install/ui/less/font-awesome/rotated-flipped.less     |   9 +++
>   install/ui/less/font-awesome/spinning.less            |  30 +++++++
>   install/ui/less/font-awesome/stacked.less             |  20 +++++
>   install/ui/less/font-awesome/variables.less           | 381
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
>   install/ui/less/rcue-white-labeled.less               |   7 ++
>   install/ui/less/rcue.less                             |  10 +++
>   install/ui/less/rcue/buttons.less                     | 160
> ++++++++++++++++++++++++++++++++++++++
>   install/ui/less/rcue/font.less                        | 139
> +++++++++++++++++++++++++++++++++
>   install/ui/less/rcue/forms.less                       | 139
> +++++++++++++++++++++++++++++++++
>   install/ui/less/rcue/navbar.less                      | 457
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
>
>


-- 
Petr Vobornik




More information about the Freeipa-devel mailing list