[Freeipa-devel] [PATCH] 0084 Make sure state of services is preserved after client uninstall

[Tomas Babej]

On 11/07/2013 05:25 PM, Ana Krivokapic wrote:
> Hello,
>
> This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3790.
>
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

Looking good..

I have two questions:


1.) Nitpick: I'd suggest we rename the save_state(service) and 
restore_state(service) to more descriptive 
save_service_state/restore_service_state?

2.) There are other places in ipa-client-install where we save and 
restore the state of the service. Having abstracted that into a 
function, should we use this at other places as well?



-- 
Tomas Babej
Associate Software Engeneer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20131115/47b0688f/attachment.htm>