[Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Ana Krivokapic]

On 11/25/2013 04:48 PM, Ana Krivokapic wrote:
> On 11/15/2013 02:26 PM, Petr Vobornik wrote:
>> Hello list,
>>
>> this is a first part of RCUE adoption effort. Main themes of this patch set are:
>>
>> - use RCUE navigation <https://fedorahosted.org/freeipa/ticket/3902>
>> - new styles for textboxes, textareas, radio/checkbox buttons and buttons-
>> part of <https://fedorahosted.org/freeipa/ticket/3904>
>> - new internal form layout (tables replaced by divs)
>> - layout does not have fixed size <https://fedorahosted.org/freeipa/ticket/3435>
>> - new dialog styles + removed dependency on jQuery UI dialog
>> - icons replaced by Font Awesome glyphs
>>
>> Example is at: <http://pvoborni.fedorapeople.org/rcue/>
>>
>> Some reasonings and additional info:
>>
>> 1. RCUE includes Bootstrap which defines o lot of styles for a lot of things.
>> That messed up the UI and therefore I did the form changes now.
>>
>> 2. jQuery UI is pretty big lib and we used it only for dialog and buttons.
>> Buttons were replaced by RCUE buttons so removal of dialog dependency was a
>> obvious step to get rid of the whole lib. The lib is removed from main UI but
>> is still present in separate pages - will be removed later.
>>
>> 3. Dojo and jQuery were upgraded to latest
>> versions.<https://fedorahosted.org/freeipa/ticket/2811>
>>
>> This approach was ACKed by Kyle from a design perspective with a note that we
>> will review and fixed some styling after second phase. We should not release
>> until then.
>>
>> The second phase, which I'm working on right now, will consist of:
>>  * login screen <https://fedorahosted.org/freeipa/ticket/3903>
>>  * new styles for standalone pages
>>  * necessary responsive enhancement (the ultimate future goal is responsive
>> layout)
>>
>> It's quite a lot of patches so I did not attach them here. You can see the
>> code in my private repo: <git://fedorapeople.org/~pvoborni/freeipa.git> branch
>> 'rcue'.
> I tested this phase of RCUE adoption effort, overall it looks and works great. A
> couple of findings:
>
> 1) Two ui integration tests are failing, I guess this is due to the re-arranging
> of elements on the automember page. So the tests should be amended to reflect
> that change.
>
> 2) In the 'Add Host' dialog, validation error messages do not have the proper
> styles. E.g. if you don't fill any values, and just click 'Add', 'Required
> field' messages appear, but they are not red, and the related fields do not get
> a red frame.
>
>

I have reviewed Petr's fix for the issue with the host adder dialog (issue 2)
above). The fix is contained in commit 829eb4f69e004c20f2d06b16ebd8d9bd176a81dd
in his private repo. I can confirm that the adder dialog now behaves correctly,
so ACK for that fix.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.