[Freeipa-devel] [PATCH] 0067 Use fqdn when creating msdcs SRV records

[Martin Kosek]

On 10/02/2013 05:24 PM, Martin Kosek wrote:
> On 10/02/2013 05:17 PM, Petr Vobornik wrote:
>> On 09/18/2013 06:42 PM, Ana Krivokapic wrote:
>>> Hello,
>>>
>>> This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3908.
>>>
>>>
>>
>> The patch does what it advertises - it uses fqdn every time for mcsdcs SRV
>> records.
>>
>> It's not consistent with other DNS SRV records, where fqdn is used only when
>> IPA server is not in the IPA DNS domain.
>>
>> bindinstance.py uses this code to address the same issue:
>>
>>     host, zone = fqdn.split(".", 1)
>>
>>         if normalize_zone(zone) == normalize_zone(self.domain):
>>             host_in_rr = host
>>         else:
>>             host_in_rr = normalize_zone(fqdn)
>>
>> Alexander suggests the same solution
>> <https://fedorahosted.org/freeipa/ticket/3908#comment:1>
> 
> Yes, I think we should be fixed.
> 
> When I was looking at the AD SRV records using this patch, it just look
> confusing - some records relative, some were absolute. This could bite us later
> when for example removing or changing these records.
> 
> Martin
> 

Given we need to fix that soon and Ana is away ATM, I am sending my candidate
patch - worked for me.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-422-use-fqdn-when-creating-msdcs-srv-records.patch
Type: text/x-patch
Size: 2088 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20131003/80fd26a9/attachment.bin>