[Freeipa-devel] [PATCH] 426, 430 Winsync re-initialize should not run memberOf fixup task

Martin Kosek mkosek at redhat.com
Fri Oct 11 08:12:18 UTC 2013


On 10/11/2013 10:00 AM, Jan Cholasta wrote:
> On 11.10.2013 09:47, Martin Kosek wrote:
>> On 10/10/2013 05:45 PM, Jan Cholasta wrote:
>>> Hi,
>>>
>>> On 9.10.2013 13:31, Martin Kosek wrote:
>>>> Change re-initialize command to consider memberOf fixup task only
>>>> for non-winsync replication agreements. This patch also includes
>>>> few fixes for DsInstance to properly set realm and fqdn properties
>>>> needed when connecting to LDAP.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/3854
>>>>
>>>
>>> -        self.realm_name = realm_name
>>> +        self.realm_name = self.realm = realm_name
>>>
>>> I think one realm property is enough. Can you please change dsinstance to use
>>> .realm instead of .realm_name?
>>>
>>> Honza
>>>
>>
>> I did not get too much into refactoring, but this one is simple. Attaching
>> updating patches.
>>
>> Martin
>>
> 
> Thanks, ACK.
> 

Pushed to master, ipa-3-3.

Martin




More information about the Freeipa-devel mailing list