[Freeipa-devel] [PATCH] 0075 Add ipa-advise plugins for nss-pam-ldapd legacy clients

[Petr Viktorin]

On 10/18/2013 04:07 PM, Alexander Bokovoy wrote:
> On Fri, 18 Oct 2013, Ana Krivokapic wrote:
>
>> On 10/18/2013 01:31 PM, Ana Krivokapic wrote:
>>> On 10/18/2013 09:48 AM, Martin Kosek wrote:
>>>> On 10/17/2013 10:29 PM, Alexander Bokovoy wrote:
>>>>> On Thu, 17 Oct 2013, Ana Krivokapic wrote:
>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> This patch adds ipa-advise plugins for configuring legacy clients
>>>>>> using
>>>>>> nss-pam-ldapd.
>>>>>>
>>>>>> https://fedorahosted.org/freeipa/ticket/3672
>>>>> Thanks. Looks good. I have one comment below
>>>>>
>>>>>> +class config_freebsd_nss_pam_ldapd(config_base_legacy_client):
>>>>>> +    """
>>>>>> +    Legacy client configuration for FreeBSD, using nss-pam-ldapd.
>>>>>> +    """
>>>>>> +    description = ('Instructions for configuring a FreeBSD system
>>>>>> with '
>>>>>> +                   'nss-pam-ldapd. ')
>>>>>> +
>>>>>> +    def get_info(self):
>>>>>> +        uri, base = self.get_uri_and_base()
>>>>>> +        cacrt = '/usr/local/etc/ipatest.crt'
>>>>> Is the cert file name is correct? 'ipatest.crt'? Perhaps 'ipaca.crt'
>>>>> would be a better name?
>>>> Or simply ipa.crt since it is the filename used everywhere else...
>>>>
>>>> Martin
>>> Cert file name changed to ipa.crt.
>>>
>>> Comment added about AES not being available on RHEL5.
>>>
>>> Updated patch attached.
>>>
>>>
>>>
>>> _______________________________________________
>>> Freeipa-devel mailing list
>>> Freeipa-devel at redhat.com
>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>
>> This updated patch improves the note about possible issues regarding
>> encryption
>> algorithms.
> Thanks. ACK.
>

Pushed to master: 92cd987e0a347123d81f83be99787ab77f39ca8e


-- 
Petr³