[Freeipa-devel] [PATCH][bind-dyndb-ldap] Fix warning duplicate 'const' declaration specifier

[Petr Spacek]

On 30.10.2013 09:21, Lukas Slebodnik wrote:
> ehlo,
>
> There were few warnings in bind-dyndb-ldap "duplicate 'const' declaration
> specifier".
>
> It does not make sense to have const twice in declaration
> like a "const settings_set_t const settings_default_set"
> This one was false positive.
>
> The 2nd warning revealed potential problem.
> const char const * dns_str
> With previous declaration, you cannot modify data, but you can modify
> pointer itself.
> *dns_str = "asdasd" //compilation error
> dns_str++           //works fine
>
> If you want to disable modification data and disable modification of pointer
> you will need to have 2nd const modifier after star "*"
>
> You can find some examples of "const" usage in attached file test.c or
> you can read article with explanation of next declaration
> "char *(*(**foo [][8])())[];"
> http://eli.thegreenplace.net/2008/07/18/reading-c-type-declarations/
>
> Simple patch is attached.

ACK, thank you for catching this. I will add you patch (with modified commit 
message) to 4.0 release.

Please be so kind and use bind-dyndb-ldap-lslebodn- prefix for your new 
patches :-)

-- 
Petr^2 Spacek