[Freeipa-devel] [PATCH] 531-541 OTP UI

[Nathaniel McCallum]

On Tue, 2014-02-04 at 18:44 +0100, Petr Vobornik wrote:
> On 4.2.2014 17:53, Nathaniel McCallum wrote:
> > On Tue, 2014-01-21 at 17:45 +0100, Petr Vobornik wrote:
> >> On 13.1.2014 17:09, Petr Vobornik wrote:
> >>> Hi,
> >>>
> >>> these patches implements the OTP Web UI.
> >>>
> >>> Last 5 patches is the OTP UI.
> >>>
> >>> First 6 patches is a little refactoring/bug fixes needed for them.
> >>> General password dialog is introduced to avoid another implementation.
> >>>
> >>> Self-service UI is implemented to be very simple. Atm user can choose
> >>> only token name. Admin interface allows to enter all values.
> >>>
> >>> It's based on the RCUE work -> we need to push RCUE first. Thanks
> >>> Nathaniel for review of the last font package. It will speed things up.
> >>>
> >>> Know bugs:
> >>> - there is clash in id's of checkboxes preventing editation of
> >>> subsequently displayed ones with the same name. Will be fixed in
> >>> separate patch.
> >>> - bugs caused by bugs in API (adding/removal of own tokens in
> >>> self-service, inability to enter key on token creation -
> >>> https://fedorahosted.org/freeipa/ticket/4099)
> >>> - datetime format (widget+validator) will be implemented in separate patch
> >>> - no support of not reviewed CLI patches (HOTP..)
> >>>
> >>> Cgit:
> >>> http://fedorapeople.org/cgit/pvoborni/public_git/freeipa.git/log/?h=otp
> >>>
> >>> https://fedorahosted.org/freeipa/ticket/3369
> >>>
> >>
> >> Patches were rebased because of minor conflict with trusted domains patch.
> >
> > Patch 531 seems to have a spacing issue (tabs instead of spaces?) at the
> > end of the first file.
> >
> > Nathaniel
> >
> 
> Are you using the rebased patches 531-1 .. 541-1? (sent on 2014-01-21)

Yes.

> They apply on master without any warning.

I found it with my eyes. :)

Just look at the bottom of the details.js section of the patch. The line
after "that.parser ..." is indented too far.

Nathaniel