[Freeipa-devel] First batch of ipatests fixes

[Tomas Babej]

On 02/05/2014 12:47 PM, Petr Viktorin wrote:
> On 02/05/2014 11:23 AM, Petr Viktorin wrote:
>> On 02/05/2014 10:29 AM, Tomas Babej wrote:
>>> Hello,
>>>
>>> the attached patches fix the following tickets:
>>>
>>> https://fedorahosted.org/freeipa/ticket/4131
>>> https://fedorahosted.org/freeipa/ticket/4130
>>> https://fedorahosted.org/freeipa/ticket/4133
>>>
>>> Details in the commit messages.
>>>
>>> Tomas
>>>
>>
>> These look good, just a few nitpicks:
>>
>> Use a lowercase "A" in option and method names in 0144 to keep
>> consistent with our naming convention.
>>
>> Add an article to the add_a_record docstring & man page:
>> Adds an A record for the host to the IPA master
>>
>> and the help text for the host argument could be better:
>> Host whose record should be added
>> (or, Host for which the record should be added)
>>
>
> Another issue, in 0145 the copyfiles_command should be run with
> raiseonerr=False, so we don't fail in cease the directory doesn't exist.
>

Thank you for the review, updated patches attached.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0144-2-ipatests-Add-records-for-all-hosts-in-master-s-domai.patch
Type: text/x-patch
Size: 5174 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140205/8a0e4d96/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0145-2-ipatests-Run-restoring-backup-files-and-restoring-th.patch
Type: text/x-patch
Size: 2492 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140205/8a0e4d96/attachment-0001.bin>