[Freeipa-devel] [PATCH] 239 Remove sourcehostcategory from the default HBAC rule

[Jan Cholasta]

On 6.2.2014 16:20, Martin Kosek wrote:
> On 02/06/2014 04:21 PM, Jan Cholasta wrote:
>> On 6.2.2014 16:04, Martin Kosek wrote:
>>> On 02/06/2014 01:16 PM, Jan Cholasta wrote:
>>>> Hi,
>>>>
>>>> the attached patch fixes <https://fedorahosted.org/freeipa/ticket/4158>.
>>>>
>>>> Honza
>>>
>>> Adding a whole new update plugin for this little change seems as a
>>> overengineering for me. Why does a simple "remove: sourcehostcategory: all" not
>>> work?
>>
>> Because there is no simple "dn: ..." to put above it, since it uses
>> auto-generated ipaUniqueId.
>
> Ah, I see.
>
>>
>>>
>>> Also, I would be OK with even just not adding it in new installation only. It
>>> is a benign attribute which also may not be deprecated in older version (and
>>> replicated) replicas.
>>
>> If it is not removed, it will still be shown in hbacrule commands' output. Is
>> it OK to remove sourcehostcategory from hbacrule.default_attributes? I'm not
>> sure why it was left there when source hosts were deprecated.
>
> Makes sense. I think removing it from default LDIF + from default_attributes
> will do the trick.
>
> Martin
>

Updated patch attached.

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-239.1-Remove-sourcehostcategory-from-the-default-HBAC-rule.patch
Type: text/x-patch
Size: 1384 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140206/ab20a1e4/attachment.bin>