[Freeipa-devel] [PATCH 0037] Fix OTP token names/labels

[Petr Vobornik]

On 11.2.2014 10:13, Jan Cholasta wrote:
> Hi,
>
> On 10.2.2014 17:42, Nathaniel McCallum wrote:
>> This is a typo patch and is therefore an easy review for an aspiring
>> reviewer. :)
>>
>> Nathaniel
>
> NACK, object_name and object_name_plural should use lower case "t" in
> "token" for consistency with other plugins.
>
> Honza
>

I have to apologize Nathaniel for wrongly pointing out the incorrect 
format of these object names attributes in different mail; I meant label 
attributes, which are correctly fixed here.

I did a simple search and it seems that we are not much consistent in 
other plugins. Some examples:

   object_name = 'Automember rule'
   object_name = _('automount location')
   object_name = _('DNS zone')
   object_name = _('host group')
   object_name = ('range')
  ------------------^ shouldn't it be idrange?

What is the main purpose of object_name/s? I can see that it's sometimes 
used in error messages, IMO not very correct usage - label might be better.
-- 
Petr Vobornik