[Freeipa-devel] [PATCHES] 0460-0463 - Fixes in project files

[Petr Viktorin]

On 02/12/2014 01:44 PM, Martin Kosek wrote:
> On 02/12/2014 01:34 PM, Petr Viktorin wrote:
>> On 02/12/2014 11:11 AM, Martin Kosek wrote:
>>> On 02/11/2014 05:18 PM, Petr Viktorin wrote:
>>>> Hello,
>>>> I have a cold and a headache today, so I could't concentrate on anything
>>>> complicated today :(
>>>> Instead I did some small changes to our project files.
>>>>
>>>> 0460: .mailmap
>>>> This fixes and deduplicates the output of `git shortlog -se`.
>>>> It also puts proper diacritics in people's names if they don't use those in
>>>> commits. The changes only appear in the shortlog.
>>>> It might be a bit controversial, I'm not insisting it needs to go in, but I'll
>>>> be using it so I'm sharing.
>>>
>>> Makes sense to me, some fixes would be needed though:
>>>
>>> 1) I see both "Endi S. Dewata" and "Endi Sukma Dewata"
>>>
>>> 2) If we want to do proper diacritics, then:
>>> s/Basti/Bašti/
>>> s/Zuna/Zůna/
>>> s/Slebodnik/Slebodník/
>>
>> Zůna? I never knew.
>> The rest is sloppiness on my part, apologies.
>>
>> Fixed, along with the issue Petr noticed (s/kbaker/kybaker/)
>>
>>>
>>>>
>>>> 0461: Contributors.txt
>>>> Jenny changed her last name.
>>>
>>> OK.
>>>
>>>>
>>>> 0462: README & BUILD.txt
>>>> Update README with current info from http://www.freeipa.org/page/Leaflet, fix
>>>> broken links, refresh build instructions.
>>>
>>> I miss some note about the AD integration, we can build it on this sentence in
>>> the leaflet:
>>>
>>> Seamless integration into Active Directory Environment via cross-realm Kerberos
>>> trust or user synchronization
>>
>> Added.
>>
>>>> 0463: Remove TODO
>>>> This file was just ancient cruft. We have trac for this.
>>>
>>> OK. I am surprised this file lasted that long :)
>>>
>>> Martin
>>
>> Thanks for the review!
>>
>> Please leave pushing to me if this is ACKed, I want to test a new patch-pushing
>> tool.
>>
>
> Looks good to me, ACK to all! Make sure the new patch-pushing tool properly
> fills Reviewed-By tag ;-)
>
> Martin
>

Thank you!
Pushed to master: 9ae2696a858e9b928436ea68180e1234ffd44ff0

-- 
Petr³