[Freeipa-devel] [PATCH 0153] ipatests: Fix incorrect order of operations when restoring

[Jan Pazdziora]

On Thu, Feb 20, 2014 at 12:20:12PM +0100, Petr Viktorin wrote:
> On 02/19/2014 04:54 PM, Jan Pazdziora wrote:
> >
> >However: since this is about restoring a backup, can't the backup
> >contain the extended attributes, so that the SELinux context gets
> >restored to the original state (which could be different from what
> >the restorecon will give you)?
> 
> Well, I guess you're the Beaker authority here. Is that necessary

This is not about Beaker, is it?

But since you mention it, beakerlib does cp -a upon backup and restore

	https://git.fedorahosted.org/cgit/beakerlib.git/tree/src/infrastructure.sh#n484
	https://git.fedorahosted.org/cgit/beakerlib.git/tree/src/infrastructure.sh#n593

for files to preserve the SELinux context, plus chcon --reference
upon backup for directories:

	https://git.fedorahosted.org/cgit/beakerlib.git/tree/src/infrastructure.sh#n495

> when restoring?
> The tests expect a "sane" state, and they return to that; using a
> somehow customized machine to test on is a bad idea anyway.

You might specifically want to run your test on non-sane state because
you want to test that the non-sane state will for example produce
correct error, SELinux-related or other.

-- 
Jan Pazdziora
Principal Software Engineer, Identity Management Engineering, Red Hat