[Freeipa-devel] [PATCHES] OTP Patches

Nathaniel McCallum npmccallum at redhat.com
Thu Feb 20 18:45:04 UTC 2014


On Wed, 2014-02-12 at 11:49 -0500, Nathaniel McCallum wrote:
> Through the review process, patches are getting shifted around, added,
> deleted, etc. So I'm now just going to be posting all the patches as an
> ordered set. The set attached is ordered according to my preferred merge
> order. It also places easy to review patches up front. I hope this helps
> reviewers. This format will definitely help me manage the patches.
> 
> The first three patches should be very easy reviews and can be merged
> independently.
> 
> All current patch critiques have, to my knowledge, been addressed in
> this latest series of patches.

Attached are 8 patches, the first 5 of which should be ready for merge:
0001-0004: Already ACK'd by abokovoy; rebased for master VERSION changes
0005: Patch by abokovy; ACK'd by me
0006-0008: New patches

Patch 0006 is a one-liner easy review.

In patch 0008, I change the existing otptoken api. How should I change
VERSION in this case since we haven't released the otptoken api yet?

Nathaniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-HOTP-support.patch
Type: text/x-patch
Size: 20774 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140220/d9e9e08d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-OTP-last-token-plugin.patch
Type: text/x-patch
Size: 13035 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140220/d9e9e08d/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-OTP-sync-support-to-ipa-pwd-extop.patch
Type: text/x-patch
Size: 56554 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140220/d9e9e08d/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Teach-ipa-pwd-extop-to-respect-global-ipaUserAuthTyp.patch
Type: text/x-patch
Size: 34809 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140220/d9e9e08d/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-libotp-do-not-call-internal-search-for-NULL-dn.patch
Type: text/x-patch
Size: 1419 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140220/d9e9e08d/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Fix-a-typo-where-self-was-omitted.patch
Type: text/x-patch
Size: 991 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140220/d9e9e08d/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Make-all-ipatokenTOTP-attributes-mandatory.patch
Type: text/x-patch
Size: 2844 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140220/d9e9e08d/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Rework-how-otptoken-defaults-are-handled.patch
Type: text/x-patch
Size: 17527 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140220/d9e9e08d/attachment-0007.bin>


More information about the Freeipa-devel mailing list