[Freeipa-devel] [freeipa] #4185: Index plugin namespaces by classes

[Dmitri Pal]

On 02/21/2014 06:31 AM, Petr Viktorin wrote:
> On 02/20/2014 08:00 PM, Dmitri Pal wrote:
>> On 02/20/2014 12:57 PM, Petr Viktorin wrote:
>>> On 02/20/2014 06:47 PM, Dmitri Pal wrote:
>>>> On 02/20/2014 12:39 PM, freeipa wrote:
>>>>> #4185: Index plugin namespaces by classes
>>>>> -------------------------------------+------------------------------------- 
>>>>>
>>>>>
>>>>>
>>>>>               Reporter:  pviktori     |                    Owner:
>>>>> pviktori
>>>>>                   Type:  refactoring  |                   Status:  
>>>>> new
>>>>>               Priority:  major        |                Milestone:  
>>>>> 0.0
>>>>>              Component:  IPA          |  NEEDS_TRIAGE
>>>>>             Resolution:               |                  Version:
>>>>>             Blocked By:               |                 Keywords:
>>>>> Affects Documentation:  0            |                 Blocking:
>>>>>       Red Hat Bugzilla:               |  Patch posted for review:  0
>>>>>            Design link:               |         External tracker:
>>>>>       Fedora test page:               |          Needs UI design:
>>>>>                 Source:               |                  Feature:
>>>>>                                       |                Expertise:
>>>>> -------------------------------------+------------------------------------- 
>>>>>
>>>>>
>>>>>
>>>>> Release Notes:
>>>>>
>>>>>
>>>>> -------------------------------------+------------------------------------- 
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Comment (by pviktori):
>>>>>
>>>>>   It's very easy to enable this so I'd like to do that now, and
>>>>> adapt the
>>>>>   rest of the code whenever it's touched.
>>>>>
>>>>
>>>> Should it be captured in some guidelines somewhere on the wiki?
>>>
>>> I was planning to add some instructions to the [Refactorings] page, as
>>> I did with the new way to register plugins.
>>> I'm open to other suggestions.
>>>
>>>
>>> [Refactorings] http://www.freeipa.org/page/V3/Refactorings
>>>
>> If we have some do and do not's it should be similar to Style guide but
>> rather developer best practices guide.
>>
>> It should be a quick reference of:
>> do not do X do Y instead
>>
>> like do not treat DN as string - use DN class
>> ...
>> use this notation instead of that notation
>> etc.
>>
>> Then we can point people to it as part of the review process.
>>
>
> Aye sir!
> http://www.freeipa.org/page/Coding_Best_Practices
> Linked from http://www.freeipa.org/page/Contribute/Code#Change_the_code
>
Thank you, Sir!

-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager for IdM portfolio
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/