[Freeipa-devel] [PATCH] Certificate search max_serial_number problem fixed

[Petr Viktorin]

On 02/25/2014 04:01 PM, Petr Viktorin wrote:
> On 02/25/2014 02:47 PM, Jan Cholasta wrote:
>> On 21.2.2014 12:11, Adam Misnyovszki wrote:
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Jan Cholasta" <jcholast at redhat.com>
>>>> To: "Adam Misnyovszki" <amisnyov at redhat.com>, freeipa-devel at redhat.com
>>>> Sent: Friday, February 21, 2014 11:05:12 AM
>>>> Subject: Re: [Freeipa-devel] [PATCH] Certificate search
>>>> max_serial_number problem fixed
>>>>
>>>> Hi,
>>>>
>>>> On 20.2.2014 18:15, Adam Misnyovszki wrote:
>>>>> Hi,
>>>>>
>>>>> this patch fixes ticket https://fedorahosted.org/freeipa/ticket/4163
>>>>> maximum serial number field now accepts only positive numbers
>>>>>
>>>>> Thanks
>>>>> Adam
>>>>
>>>> I think you should also add maxvalue to min_serial_number, so that they
>>>> are consistent.
>>>>
>>>> Honza
>>>>
>>>> --
>>>> Jan Cholasta
>>>>
>>>
>>> Makes sense, new patch added.
>>>
>>> Adam
>>>
>>
>> Thanks, ACK.
>>
>
> Pushed to master: be7b1b94e300b137c34bab80df3dc91195259c89


Adam, you have not updated API.txt. To do this you need to run the 
makeapi script when changing the API. When you run `make rpms` you will 
be warned if there is a mismatch.
FWIW, I have the following in my .git/hooks/post-commit, so Git alerts 
me of problems after a commit:

     ./makeapi
     git status --short  # Show modified files, mainly for the case that 
makeapi modified API.txt



Honza, please make sure IPA actually builds before you ACK a patch.


Attached fix pushed as one-(well,two)-liner to master: 
00d6b529c977c19fc5bb2e230da551ac01c79d79

-- 
Petr³

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0472-Update-API.txt.patch
Type: text/x-patch
Size: 1226 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140225/9a9100c2/attachment.bin>