[Freeipa-devel] [PATCHES] 225-230 Drop support for the legacy LDAP API

[Jan Cholasta]

On 16.12.2013 14:45, Petr Viktorin wrote:
> On 12/16/2013 10:22 AM, Jan Cholasta wrote:
>> On 13.12.2013 15:16, Petr Viktorin wrote:
>>> On 12/10/2013 04:05 PM, Jan Cholasta wrote:
>>>> Hi,
>>>>
>>>> I believe the time has come to drop support for the legacy (dn,
>>>> entry_attrs) tuple API and move to the new LDAPEntry API exclusively.
>>>> The attached patches convert existing code which uses the old API to
>>>> the
>>>> new API and remove backward compatibility code from the ipaldap module.
>>>>
>>>> Note that there are still some functions/methods which accept separate
>>>> dn and entry_attrs arguments, they will be adapted to LDAPEntry later.
>>>>
>>>> Honza
>>>
>>> The first N-1 patches can be tested,acked,pushed independently, right?
>>
>> Yes.
>>
>>> If that's the case, ACK for 225
>
> Pushed that one to master, 5 more to go.
> bc3f3381c6bf0b4941889b775025a60f56318551
>
>>> As for dropping the support itself, I think we should think more about
>>> backward compatibility. This will affect nearly all third-party plugins,
>>> and I'm sure there are a few.
>>
>> Are there?
>
> Yes, there are some private plugins in the wild.
>
>>> I'd recommend something like:
>>> 3.4: Warn in release notes that we'll be dropping support; log a warning
>>> when __iter__ is used
>>> 3.5: Make __iter__ raise an exception (we don't want to silently start
>>> returning different data)
>>> 3.6: Finally start acting like a dict
>>
>> Could we raise an exception now instead of waiting for 3.5? Fixing the
>> plugins is nothing hard, you know...
>
> We should discuss this next year, when people come back from holidays.

We had an offline discussion and decided to raise an exception in 3.4 
and drop support in 3.5.

I have created a wiki page with migration guide: 
<http://www.freeipa.org/page/HowTo/Migrate_your_code_to_the_new_LDAP_API> (WIP, 
comments/edits are welcome).

Updated patches attached.

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-226.1-Convert-remaining-frontend-code-to-LDAPEntry-API.patch
Type: text/x-patch
Size: 100845 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140107/18aaac1a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-227.1-Convert-remaining-installer-code-to-LDAPEntry-API.patch
Type: text/x-patch
Size: 14360 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140107/18aaac1a/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-228.1-Convert-remaining-update-code-to-LDAPEntry-API.patch
Type: text/x-patch
Size: 10420 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140107/18aaac1a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-229.1-Convert-remaining-test-code-to-LDAPEntry-API.patch
Type: text/x-patch
Size: 3334 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140107/18aaac1a/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-230.1-Raise-an-exception-when-legacy-LDAP-API-is-used.patch
Type: text/x-patch
Size: 3802 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140107/18aaac1a/attachment-0004.bin>