[Freeipa-devel] [PATCH] 0133 Use standard_list_of_entries for trust-resolve

[Alexander Bokovoy]

On Wed, 15 Jan 2014, Alexander Bokovoy wrote:
>>I am personally not convinced this is the right way to fix #4113, for
>>several reasons:
>>
>>1) The output modification will most probably break FreeIPA 3.2.x or
>>FreeIPA 3.3.x clients who expect different output (the command was
>>introduced in https://fedorahosted.org/freeipa/ticket/3302).
>This command is only used within Web UI. It is not supposed to be used
>by CLI for anything, it was marked for CLI only for some QE request at
>the time we still had issues with SID resolution in sssd. I'd rather
>mark it NO_CLI=True because it is really a tool for Web UI asynchronous
>resolution of SIDs to names for external members of groups.
Also note that from Web UI side the output change proposed in this patch
is an extension of what Web UI expects. All the old fields are the same,
it is only a bit of metadata added alongside with previously provided
'result' array. Since Web UI references data by field name, no change is
needed:

   sidxlate_command.on_success = function(data, text_status, xhr) {
       for (var i=0; i< data.result.result.length; i++) {
           var entry = data.result.result[i];
           if (entry.sid[0] in xlate) {
               xlate[entry.sid[0]].resolve(entry.name[0]);
           }
       }
   };


-- 
/ Alexander Bokovoy