[Freeipa-devel] [PATCH] 1106 IPA REST smart proxy

Petr Viktorin pviktori at redhat.com
Thu Jan 23 13:17:47 UTC 2014


On 01/22/2014 08:04 PM, Rob Crittenden wrote:
> Petr Viktorin wrote:
>> On 01/20/2014 05:21 PM, Rob Crittenden wrote:
>>> Petr Viktorin wrote:
>>>> On 01/17/2014 10:24 PM, Rob Crittenden wrote:
>>>>> Implement an IPA RESTful Foreman-compatible smart proxy. This exposes
>>>>> hosts and hostgroups via an unauthenticated REST API. The idea is that
>>>>> this service runs on the Foreman server and only listens on local
>>>>> ports.
>>>>>
>>>>> It is a CherryPy-based server and that handles the majority of REST
>>>>> for us.
>>>>>
>>>>> I included some tests, they can be executed with: nosetests -v
>>>>> smartproxy/tests
>>>>
>>>> Why is it not a part of ipatests?
>>>
>>> I can move it if it's a show-stopper. It seemed specific to this one
>>> directory so I stuck it there. It isn't relevant for most testing and
>>> requires some manual configuration (though CI could handle it).
>>
>> Not strictly a show stopper, but please move it. At the very least it
>> should end up in the freeipa-tests package.
>
> Moved.

Thanks!

>> A lot of the tests (integration, webUI) need manual configuration, so
>> this would be no exception. Of course the tests should be skipped if the
>> configuration was not done, and the config instructions should be added
>> to/linked from http://www.freeipa.org/page/Testing
>
> Hmm, maybe. There are instructions to set up the environment in the man
> page. Testing beyond that consists of ./make-test tests/test_smartproxy
>
> I can add that testing bit once the patch is approved I suppose.
>
> rob

Please add python-kerberos >= 1.1-13 to Requires and BuildRequires; 
pylint fails with lower versions.
Are there plans to release python-kerberos-1.1-13.fc20, or will this be 
f21+ only?

-- 
Petr³




More information about the Freeipa-devel mailing list