[Freeipa-devel] [PATCH] 680-682 webui: validation reporting improvements

[Endi Sukma Dewata]

On 7/1/2014 3:47 AM, Petr Vobornik wrote:
>> This should be sufficient to close #4057. But just wondering, the Realm
>> Domains page right now is implemented as a details page with a
>> multi-valued widget. Would it make more sense to be a list page instead?
>> The realmdomains-mod CLI is kind of unusual too with the
>> --add/del-domain parameters. Why not use realmdomain-add/del commands?
>> Are there other commands implemented in this fashion?
>
> Wrt CLI: Depends how you look at it and if/how much should our CLI/API
> reflect data structure.
>
> If you say, we have an object which contains/manages the realm domains
> used by IPA server, then it's implemented as in every other similar
> object with multivalued attribute. But it's also a singleton therefore
> the closest similar thing is a configuration. There could also be an
> argument that this functionality could have been added to config itself.
>
> If you say that each realm domain is an object or if you don't want to
> reflect the data structure and just focus on API then it's not
> implemented the best way.
>
> Wrt Web UI: Makes sense. The list UI would fit better (until the
> realmdomains object is extended by additional attr).

I think we should design CLI/UI from user's perspective because it's an 
interface after all, regardless of how it's stored on the server. Right 
now the design seems to be based on assumption that there won't be many 
realm domains (e.g. no need to search, no need to page), and there's no 
other attributes required for each realm domain (e.g. no description, no 
owner, etc.). But as soon as the assumption is no longer correct the 
current interface is no longer adequate. Treating realm domains as 
separate objects I think is more future-proof.

-- 
Endi S. Dewata