[Freeipa-devel] [PATCH 0082] Forward zones: add warning about forwarders semantic change in dnszone-add/mod

[Martin Basti]

On Tue, 2014-07-01 at 12:17 +0200, Petr Viktorin wrote:
> On 07/01/2014 12:10 PM, Martin Basti wrote:
> > On Mon, 2014-06-30 at 13:57 +0200, Petr Viktorin wrote:
> >> On 06/30/2014 12:48 PM, Martin Basti wrote:
> >>> Ticket: https://fedorahosted.org/freeipa/ticket/3210#comment:16
> >>> Patch attached.
> >>>
> >>
> >> When you add a new message, you should also define a new class for it in
> >> messages.py with a new errno, not just reuse PublicMessage with a custom
> >> string.
> >>
> >>
> >
> > Could it be WarningMessage? Or should I be more specific
> > ForwardersWarningMessage, DNSSECWarningMessage ?
> 
> Be specific. I'd go for DNSSECWarning; "message" is already in the 
> module name.
> 
> > Is there any rule how to choose errno?
> 
> Just use the next unused one.
> 
> 
Updated patch attached

-- 
Martin^2 Basti
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0082-2-Add-warning-about-semantic-change-for-zones.patch
Type: text/x-patch
Size: 4278 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140701/f7bfb3c9/attachment.bin>