[Freeipa-devel] [PATCHES 0084-0086] NSEC3PARAM DNS record should be in DNS zone settings

[Petr Vobornik]

On 2.7.2014 14:27, Martin Basti wrote:
> On Wed, 2014-07-02 at 13:17 +0200, Martin Basti wrote:
>> On Wed, 2014-07-02 at 09:39 +0200, Petr Viktorin wrote:
>>> On 07/01/2014 03:15 PM, Martin Basti wrote:
>>>> On Tue, 2014-07-01 at 14:24 +0200, Martin Basti wrote:
>>>>> Ticket: https://fedorahosted.org/freeipa/ticket/4413
>>>>> Patches attached
>>>
>>>>
>>>> Rebased patches attached
>>>>
>>>
>>>
>>> 0084:
>>> in dns.py, you'll also want to remove NSEC3PARAMRecord from
>>> _dns_records. Otherwise I still see it in API.txt for dnsrecord_add &
>>> friends.
>> If remove it, it breaks dns.py. I havent add NSEC3PARAMRecord into _dns_records in original patch.
>>
>>> 0085:
>>> _nsec3param_errmsg will not get picked up by xgettext, so it won't be
>>> translated. The argument to _() must be a literal string, not a variable.
>>>
>>>
>>>
>>
>>
> Updated patch attached (API.txt updated)
>

ACK

pushed to master:
* ff7b44e3b09b2e94fde66f918a6d1fb6db043d80 Remove NSEC3PARAM record
* 30551a8aa30dcd39b3ae4c2fe97a163620773730 Add NSEC3PARAM to zone settings
* 01b95805ab1428e10c79abf70c9bc9e2baf9de21 NSEC3PARAM tests

-- 
Petr Vobornik