[Freeipa-devel] [PATCH 0093] Restore priviledges after forward zone upgrade

[Martin Basti]

On Fri, 2014-07-04 at 12:51 +0200, Petr Viktorin wrote:
> On 07/03/2014 09:24 PM, Petr Spacek wrote:
> > On 3.7.2014 19:00, Martin Basti wrote:
> >> Patch attached
> >
> > Congratulations! I wasn't able to find any bug in this ;-)
> >
> > ACK from functional perspective.
> >
> > It can be pushed if there is no problem with Python side of things.
> >
> 
> 
> 
> Martin, I see a lot of code like this:
>     zone['idnsname'][0]
> To get a single-valued attribute, you should use:
>     zone.single_value['idnsname']
> which does a proper check that there is really only a single value.
> 
> I see the old style used elsewhere in the plugin though; it should be 
> changed everywhere, and I don't think there's immediate benefit to doing 
> that. Just keep this in mind for the future.
> 
> 
> Pushed 0093 to master: f8b6595f4999740a704bcdae6d4f9b5021f7f61f
> 

Thank you for the hint.
If I have a time I will fix it in dns plugin(s)
-- 
Martin^2 Basti