[Freeipa-devel] [PATCH] 0001 Fix ipa-client-install --uninstall crash

[Petr Viktorin]

On 07/08/2014 07:59 AM, David Kupka wrote:
>
> On 07/07/2014 09:15 PM, Petr Viktorin wrote:
>> On 07/04/2014 08:47 AM, David Kupka wrote:
>>> https://fedorahosted.org/freeipa/ticket/4273
>>>
>>> David Kupka
>>
>> Hi,
>> This works fine. Just two nitpicks in the log message:
>> - "%s" means "convert to string", so the str() is redundant
>> - the logger methods take items to interpolate as arguments, instead
>> of one string built with %.
>>
>> So you'll want:
>>     root_logger.error('Failed to start chronyd: %s', e)

Sorry for not replying to list.

> Hi,
> thanks for comments. I've fixed the patch accordingly.

Thanks!
ACK, pushed to:
master: 2ff14607b170c86ccd93cff60f5a34d64cd1e419
ipa-4-1: 2ff14607b170c86ccd93cff60f5a34d64cd1e419
ipa-4-0: 2ff14607b170c86ccd93cff60f5a34d64cd1e419


-- 
Petr³