[Freeipa-devel] [PATCH] 0002 Improve password validity check

[Martin Kosek]

On 07/18/2014 12:33 PM, David Kupka wrote:
> https://fedorahosted.org/freeipa/ticket/2796

1) Would it be easier/more convenient to just implement following simple check
instead of bad_prefix/bad_suffix?

if password.strip() != password:
   raise ValueError('Password must not start or end with whitespace')


2) The main goal of the ticket 2796 was not fixed yet. It sometimes happen that
when installation crashes somewhere right after pkicreate, it does not record
and and does not uninstall the PKI component during "ipa-server-install
--uninstall".

You may artificially invoke some crash in cainstance.py after pkicreate to test
it. When fixing it, check how is_configured() in Service object works an how
self.backup_state is called in other service modules (like dsinstance.py) where
the detection works correctly.

Martin