[Freeipa-devel] [PATCH] 697-702 webui: usability improvements in attribute widget

[Petr Vobornik]

On 18.7.2014 00:06, Endi Sukma Dewata wrote:
> On 7/10/2014 8:02 AM, Petr Vobornik wrote:
>
> ACK. Comments below:
>
>>> == [PATCH] 699 webui: optimize (re)creation of option widget ==
>>>
>>> There is a case where attributes widget can contain > 1000 items.
>>> It's about 3000 nodes. It's slow in jQuery. Simple move to dojo
>>> speeds it up (is closer to native calls) while maintaining developer
>>> friendliness.
>>>
>>> Now the biggest lag is in browser's render. It's probably not worth
>>> developer time to optimize that.
>
> Is it common to have many items in this widget (doesn't have to be
> bigger than 1000, but just large enough)? Maybe the UI should provide
> some kind of paging interface, not just for performance reason, but also
> for usability.

It's not common, it's only in one case and therefore IMO we don't have 
to spend more time on this issue.

WRT paging: IMHO the classic one won't help, but 'infinite scroll 
paging' might. I would rather see this type of paging on search facets 
first.

>
>>> == [PATCH] 700 webui: custom attr in attributes widget ==
>>>
>>> Web UI doesn't always know what are the possible attributes
>>> for target object. This will allow to add custom attributes
>>> if necessary.
>
> Right now you can add an undefined attribute, but it will fail when you
> try to save it. Should the UI perform a schema validation before
> accepting the new attribute? Or should the UI provide a list of valid
> attributes?
>

If we knew the list of valid attrs/schema we would not need this patch.



pushed to:

master:
* b68f819de75073285c17c28a30afe5b5dbfe5176 webui: improve usability of 
attributes widget
* 740d42257fc00235b1cebdc90866fe34bf9464b3 webui: add filter to 
attributes widget
* 9fa447cb6e5f1476072cf167eec8502cfc3e38e3 webui: optimize (re)creation 
of option widget
* 4aefc0d6fe7a4879a9b8024eb7424b4dfa5fa7ca webui: custom attr in 
attributes widget
* d2f2fc5addc0634b24ccda7a5aae1ed1d3c6001a webui: attr widget: get list 
of possible attrs from ipapermdefaultattr
* 8fcf6d6b34400c1924f509701856b86e4f647624 webui: option_widget_base: 
sort options
ipa-4-1:
* b68f819de75073285c17c28a30afe5b5dbfe5176 webui: improve usability of 
attributes widget
* 740d42257fc00235b1cebdc90866fe34bf9464b3 webui: add filter to 
attributes widget
* 9fa447cb6e5f1476072cf167eec8502cfc3e38e3 webui: optimize (re)creation 
of option widget
* 4aefc0d6fe7a4879a9b8024eb7424b4dfa5fa7ca webui: custom attr in 
attributes widget
* d2f2fc5addc0634b24ccda7a5aae1ed1d3c6001a webui: attr widget: get list 
of possible attrs from ipapermdefaultattr
* 8fcf6d6b34400c1924f509701856b86e4f647624 webui: option_widget_base: 
sort options
ipa-4-0:
* b68f819de75073285c17c28a30afe5b5dbfe5176 webui: improve usability of 
attributes widget
* 740d42257fc00235b1cebdc90866fe34bf9464b3 webui: add filter to 
attributes widget
* 9fa447cb6e5f1476072cf167eec8502cfc3e38e3 webui: optimize (re)creation 
of option widget
* 4aefc0d6fe7a4879a9b8024eb7424b4dfa5fa7ca webui: custom attr in 
attributes widget
* d2f2fc5addc0634b24ccda7a5aae1ed1d3c6001a webui: attr widget: get list 
of possible attrs from ipapermdefaultattr
* 8fcf6d6b34400c1924f509701856b86e4f647624 webui: option_widget_base: 
sort options


-- 
Petr Vobornik