[Freeipa-devel] [PATCH] 129 ipa-kdb: fix unit tests

Sumit Bose sbose at redhat.com
Tue Jul 22 15:24:51 UTC 2014


Hi,

it looks like the ipa-kdb unit test is broken. This patch tries to fix
it.

bye,
Sumit
-------------- next part --------------
From 5de7f5790d895251c7a22b6af804ac5c61c553c4 Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Tue, 22 Jul 2014 17:17:45 +0200
Subject: [PATCH] ipa-kdb: fix unit tests

---
 daemons/ipa-kdb/Makefile.am           | 1 +
 daemons/ipa-kdb/tests/ipa_kdb_tests.c | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/daemons/ipa-kdb/Makefile.am b/daemons/ipa-kdb/Makefile.am
index b3d6a1b5eaaebbbd1dd01126901bcf01c5dcd10f..80747491f8315a9cb0b38965423ba5d160946278 100644
--- a/daemons/ipa-kdb/Makefile.am
+++ b/daemons/ipa-kdb/Makefile.am
@@ -79,6 +79,7 @@ ipa_kdb_tests_LDADD =          \
        $(KRB5_LIBS)            \
        $(LDAP_LIBS)            \
        $(NDRPAC_LIBS)          \
+       $(UNISTRING_LIBS)       \
        $(NSS_LIBS)             \
        -lkdb5                  \
        -lsss_idmap             \
diff --git a/daemons/ipa-kdb/tests/ipa_kdb_tests.c b/daemons/ipa-kdb/tests/ipa_kdb_tests.c
index fbee4acdbe8d6426664aef8e2d826ef6c065a514..e1ae06a6e359e65873241116581f028f1a4e1bf3 100644
--- a/daemons/ipa-kdb/tests/ipa_kdb_tests.c
+++ b/daemons/ipa-kdb/tests/ipa_kdb_tests.c
@@ -174,7 +174,9 @@ START_TEST(test_get_authz_data_types)
     for (c = 0; test_set[c].authz_data != NULL ||
                 test_set[c].global_authz_data != NULL; c++) {
         ied->authz_data = test_set[c].authz_data;
-        ipa_ctx->authz_data = test_set[c].global_authz_data;
+        ipa_ctx->config.authz_data = test_set[c].global_authz_data;
+        /* Set last_update to avoid LDAP lookups during tests */
+        ipa_ctx->config.last_update = time(NULL);
         entry->princ = test_set[c].princ;
         get_authz_data_types(krb5_ctx, entry, &with_pac, &with_pad);
         fail_unless(with_pad == test_set[c].exp_with_pad, "with_pad not %s %s.",
-- 
1.8.5.3



More information about the Freeipa-devel mailing list