[Freeipa-devel] [PATCH 0245] baseldap: Remove redundant search from LDAPAddReverseMember

Jan Cholasta jcholast at redhat.com
Wed Jul 23 13:03:09 UTC 2014


On 23.7.2014 14:40, Tomas Babej wrote:
> Hi,
>
> when poking in the depths of the baseldap, I found this seemingly
> redundant search.

ACK. For the record, before commit f1f1b4e the result was used for 
wait_for_memberof.

BTW, I think this bit:

         # Ensure our target exists
         result = self.api.Command[self.show_command](keys[-1])['result']
         dn = result['dn']

could be optimized to use get_dn_if_exists.

-- 
Jan Cholasta




More information about the Freeipa-devel mailing list