[Freeipa-devel] [PATCH] ipa trust-add command should be interactive

[Gabe Alford]

Nope. Somehow in my head it felt cleaner. Updated patched attached.


On Wed, Jul 23, 2014 at 1:18 AM, Jan Cholasta <jcholast at redhat.com> wrote:

> On 23.7.2014 01:01, Gabe Alford wrote:
>
>> Forgot about --trust-secret. Here is an updated patch.
>>
>>
>> On Mon, Jul 21, 2014 at 2:31 AM, Jan Cholasta <jcholast at redhat.com
>> <mailto:jcholast at redhat.com>> wrote:
>>
>>     On 21.7.2014 10:28, Martin Kosek wrote:
>>
>>         On 07/21/2014 09:56 AM, Jan Cholasta wrote:
>>
>>             Hi,
>>
>>             On 16.7.2014 05:48, Gabe Alford wrote:
>>
>>                 Hello,
>>
>>                 Adds AD admin and password to interactive commands.
>>                 https://fedorahosted.org/__freeipa/ticket/3034
>>
>>                 <https://fedorahosted.org/freeipa/ticket/3034>
>>
>>                 Thanks,
>>
>>                 Gabe
>>
>>
>>             I think that instead of making the parameters mandatory, you
>>             should instead set
>>             alwaysask=True on them.
>>
>>             Honza
>>
>>
>>         Trust can be established either with user+password options OR with
>>         --trust-secret option - i.e. you cannot use mandatory options
>>         nor alwaysask.
>>
>>
>>     Ah, right.
>>
>>
>>
>>         This would rather lead to interactive_prompt_callback checking
>>         if any of
>>         authentication method is passed and asking for them if they
>> aren't.
>>
>>
>>     +1
>>
>>
>>         Martin
>>
>>
>>
>>     --
>>     Jan Cholasta
>>
>>
>>
> I don't think using an extra function to update a value in a dictionary is
> very beneficial, is there a reason not to use "kw[X] =
> self.prompt_param(self.params[X])" directly?
>
> --
> Jan Cholasta
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140723/915b8735/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rga-0024-3-ipa-trust-add-command-should-be-interactive.patch
Type: text/x-patch
Size: 2402 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140723/915b8735/attachment.bin>