[Freeipa-devel] [PATCH 0246] baseldap: Fix undefined variable reference in
Rob Crittenden
rcritten at redhat.com
Thu Jul 24 13:21:11 UTC 2014
Tomas Babej wrote:
>
> On 07/24/2014 12:35 PM, Tomas Babej wrote:
>> Hi,
>>
>> on receiving a PublicError we fail with InternalError since msg is not
>> defined.
>>
>>
>>
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>
> I also realized there's no need for the nested try-blocks, so added some
> refactoring to the fix, which makes the code much more simple.
Please open a ticket for this.
Also note that the exc_wrapper may raise an exception which I believe is
why I nested the exception originally. It may be no longer needed but
worth a second look.
rob
More information about the Freeipa-devel
mailing list