[Freeipa-devel] [PATCH] 712 webui: detach facet nodes

Petr Vobornik pvoborni at redhat.com
Mon Jul 28 12:11:51 UTC 2014


On 25.7.2014 22:27, Endi Sukma Dewata wrote:
> On 7/23/2014 8:25 AM, Petr Vobornik wrote:
>> Detach/attach facet nodes when switching facets instead of
>> hiding/showing.
>>
>> Keeps dom-tree more simple.
>>
>>
>> This patch is not really needed. I implemented it while testing
>> something in IE. But it might have positive effect for poorly written
>> parts of Web UI(if there are any :) ) or plugins. Basically it
>> simplifies DOM tree to contain nodes only for the active facet.
>> Therefore ugly expressions like $('button .foobar') are much more
>> performant.
>
> ACK. In the future the entire facet itself probably can even be loaded
> dynamically, so this is a step in that direction. The "facet" element
> itself probably can be merged with the "content" element since there's
> only one facet/content at any time.
>

Btw, what do you mean by "loaded dynamically"? Loading of source files 
on demand or just instantiating of facets or something else?

The latter is partially implemented (facets of given entity are 
instantiated when one of them is requested).

Loading of source files might be little bit more difficult since we have 
entity-centered sources and some information from all entities are 
required right at the start of the app, e.g. for menu.
-- 
Petr Vobornik




More information about the Freeipa-devel mailing list