[Freeipa-devel] [PATCH 0029-0046, 0047] Internationalized domain names in DNS plugin
Martin Kosek
mkosek at redhat.com
Tue Jun 3 14:02:21 UTC 2014
On 06/03/2014 02:06 PM, Jan Cholasta wrote:
> On 3.6.2014 11:45, Martin Basti wrote:
>>>>
>>>>
>>>>>>
>>>>>> Patch 38:
>>>>>>
>>>>>> It seems you left out the normalize_zonemgr and normalize_zone
>>>>>> modifications I have suggested. Is there a reason for this?
>>>>>>
>>>>> I left there original code, which works with strings.
>>>>>
>>>>> I dont use normalize_zone in DNS plugin anymore. So it would be better
>>>>> to work only with string, no conversion string to object and back to
>>>>> string.
>>>>>
>>>>> Should I modify normalize_zonemgr then? Old version works good, and code
>>>>> will be little longer than your example.
>>>
>>> Yes please, just to be safe ;-)
>>>
>>
>> Patch attached.
>>
>
> Thanks, ACK on everything.
>
> (Note that webui code needs to be updated to understand DNS names in RPC.)
>
Pushed all to master.
Thanks for careful review.
Martin
More information about the Freeipa-devel
mailing list