[Freeipa-devel] [PATCH] 592-628 Update to PatternFly

[Endi Sukma Dewata]

ACK for patches #592-#628. I'll continue reviewing the rest.

There are some minor/unrelated issues I found while testing but they can 
be addressed separately:

1. In the login page the message says "To login with username and 
password, enter them in the fields below," but the fields are actually 
displayed on the left of the message in desktop mode (big screen) or 
above the message in mobile mode (small screen).

2. If there's a login error, the logo and the message shifts up. I think 
it would be nicer to display the error without changing the layout of 
the original page.

3. In the login page the "configured" link goes to unauthorized.html 
which displays "Unable to verify your Kerberos credentials" message. I 
think people expect to see an instruction to configure the browser, not 
an error message.

4. In the list page (e.g. Users) in mobile mode the Refresh button may 
overlap the search box.

5. In mobile mode the list table loses the outer border. Is this 
intentional? If so, maybe the left/right margin could be removed as well 
to maximize the horizontal space.

6. In desktop mode if the page is narrower than a certain width the 
table cell content may wrap (i.e. "First name" will be displayed in 2 
lines).

7. If the list table is empty, the cell borders disappear (see Host 
Groups page).

8. In mobile mode if you click the menu icon on the top right there will 
be 2 scrollbars, one for the whole page, and one for the menu itself. I 
think in mobile mode the menu should occupy the entire page, so there's 
only one scrollbar.

9. In mobile mode if you select Policy from the menu it will show the 
HBAC Rules page. Similarly, if you click IPA Server it will show the 
Roles page. This can be confusing since in mobile mode we don't see the 
navigation hierarchy. Probably the breadcrumb needs to include the full 
hierarchy (e.g. Policy >> HBAC >> Rules). Alternatively, the menu items 
that don't have a corresponding page shouldn't be clickable.

10. In mobile mode the Available and Prospective tables in the 
association dialog are arranged vertically, but the Add and Delete 
arrows are still pointing horizontally.

11. In desktop mode the QR code for new OTP token is displayed outside 
the dialog box.

12. There seems to be a caching issue. I added a user, then I added an 
automember rule that will add the user to a group. When I opened the 
user details page initially, the "User Groups" tab header was showing 
it's a member of 1 group. Then I rebuilt auto membership and reopened 
the page, it's still showing 1 group. Then I clicked another tab (e.g. 
Netgroups) it's now showing 2 groups. But if I clicked "User Groups" tab 
it went back to 1 group. To get the right info I had to click Refresh. I 
think the counter in the tab header should be based on the cached tab 
content. Alternatively, rebuilding automember should invalidate the cache.

-- 
Endi S. Dewata