[Freeipa-devel] [PATCHES 21-22] ipautil log messages and API version to env

[Gabe Alford]

Patch 21:
Update per recommendation

Patch 22:
Added version option as well as updated the manpage.

Thanks,

Gabe


On Fri, Jun 6, 2014 at 5:47 AM, Petr Viktorin <pviktori at redhat.com> wrote:

> On 06/06/2014 08:36 AM, Gabe Alford wrote:
>
>> Hello,
>>
>> Patch 21:
>> This is a patch for https://fedorahosted.org/freeipa/ticket/3724
>>
>
> Nope, doesn't work for me: nolog_replace expects a string.
>
>  File "/usr/lib/python2.7/site-packages/ipaserver/install/installutils.py",
> line 639, in run_script
>     return_value = main_function()
>   File "/usr/sbin/ipa-upgradeconfig", line 1140, in main
>     certificate_renewal_update(ca),
>   File "/usr/sbin/ipa-upgradeconfig", line 691, in
> certificate_renewal_update
>     ca.configure_renewal()
>   File "/usr/lib/python2.7/site-packages/ipaserver/install/cainstance.py",
> line 1444, in configure_renewal
>     post_command='renew_ca_cert "%s"' % nickname)
>   File "/usr/lib/python2.7/site-packages/ipapython/certmonger.py", line
> 431, in dogtag_start_tracking
>     (stdout, stderr, returncode) = ipautil.run(args, nolog=[pin])
>   File "/usr/lib/python2.7/site-packages/ipapython/ipautil.py", line 305,
> in run
>     arg_string = nolog_replace(args, nolog)
>   File "/usr/lib/python2.7/site-packages/ipapython/ipautil.py", line 360,
> in nolog_replace
>     string = string.replace(nolog_value, 'XXXXXXXX')
>
>
> I'd recommend something like ' '.join(shell_quote(a) for a in args).
>
>
>  Patch 22:
>> This is part of https://fedorahosted.org/freeipa/ticket/4316 and adds
>> the API to 'ipa env'
>>
>> One question that I had for adding 'ipa --version' is if using the
>> default optparse version argument would be sufficient/intended i.e.
>> version=('Version: %s, API_Version: %s' % (version, api_version) or if a
>> custom optparse argument is needed.
>>
>
> I think the default will be just fine. Can you update the patch to add the
> option?
>
> --
> Petrł
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140606/bbd24683/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rga-0022-2-Add-version-and-API-version.patch
Type: text/x-patch
Size: 3391 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140606/bbd24683/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rga-0021-2-ipautil.run-args-log-message-is-confusing.patch
Type: text/x-patch
Size: 919 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140606/bbd24683/attachment-0001.bin>