[Freeipa-devel] [PATCHES] Update plugins to use Registry API

Nathaniel McCallum npmccallum at redhat.com
Tue Jun 10 15:29:11 UTC 2014


On Tue, 2014-06-10 at 16:45 +0200, Jan Cholasta wrote:
> Hi,
> 
> On 6.6.2014 20:33, Nathaniel McCallum wrote:
> > I kept seeing the old plugin registration style when writing/reviewing
> > code and I decided to fix it. Attached are patches to update the
> > remaining 31 plugins from the old plugin registration style to the new
> > style.
> >
> > This would be a great starting point for someone new to doing reviews.
> >
> > Nathaniel
> 
> I can't imagine a situation in which having these in separate commits 
> would be beneficial, so I don't think this really deserves to be split 
> among multiple patches.

My thought was to make it easier to review in small chunks for new
reviewers. But if we want to do it as a single patch, one is attached.

Nathaniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Update-all-remaining-plugins-to-the-new-Registry-API.patch
Type: text/x-patch
Size: 86787 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140610/55b9dc77/attachment.bin>


More information about the Freeipa-devel mailing list