[Freeipa-devel] [PATCH] 645 webui: display only dialogs which belong to current facet

[Endi Sukma Dewata]

On 5/29/2014 10:15 AM, Petr Vobornik wrote:
> On 27.5.2014 12:49, Petr Vobornik wrote:
>> Dialog instances no longer directly call IPA.opened_dialog methods. It's
>> handled through events (decoupled from dialog's POV). IPA.open_dialogs
>> with assistance of ApplicationController makes sure that there is only
>> one dialog opened at the same time.
>>
>> It also makes sure to hide all dialogs, which are not global dialogs and
>> did not originate from current facet, when switching facets.
>>
>> https://fedorahosted.org/freeipa/ticket/4348
>>
>
> Attaching rebased version (on top of latest PatternFly patch set).

ACK, but see comments below:

1. Let's say I had a dialog open and I clicked the button to execute the 
operation but the session expired so I'd get a login screen. Once I 
relogged in, the operation was executed immediately without a chance to 
review the operation. I think it's safer to require the user to reclick 
the button (i.e. the UI ignores the user action that happens while the 
session expired).

2. Can this expression

   !facet || (facet && dialog.facet === facet)

be simplified into this?

   !facet || dialog.facet === facet

3. Unrelated. In self-service user page the action menus for Disable, 
Delete, and Rebuild auto membership are enabled although the user 
doesn't have the rights to execute those actions.

-- 
Endi S. Dewata