[Freeipa-devel] [PATCH 0224] cainstance: Read CS.cfg for preop.pin in a loop

Nathaniel McCallum npmccallum at redhat.com
Wed Jun 11 16:49:06 UTC 2014


On Wed, 2014-06-11 at 11:08 +0200, Tomas Babej wrote:
> Hi,
> 
> As due to possible race conditions, the preop.pin might not be
> written in the CS.cfg at the time installer tries to read it.
> 
> In case no value for preop.pin was found, retry until timeout
> was reached.
> 
> https://fedorahosted.org/freeipa/ticket/3382
> 
> (applies on ipa-3-0 branch)

There is inconsistent spacing around '='. For instance:
+            f=open(filename, 'r')
+            data = f.read()

Also, I'm fairly certain this is incorrect:
+                total_timeout =+ 1

Nathaniel




More information about the Freeipa-devel mailing list