[Freeipa-devel] [PATCH] 0059-0064 Update DNSSEC attributes/record types

[Petr Vobornik]

On 9.6.2014 17:28, Martin Basti wrote:
> Ticket: https://fedorahosted.org/freeipa/ticket/4328
>
> Petr please make the WebUI patch review (0062) :-)
>
> Patches attached.
>

Patch #0059: LGTM

Patch #0060:

1. Please add `pattern_errmsg` to `salt` part of nsec3param. Otherwise 
you get general "Text does not match field pattern" error message in Web UI.

2. Could be in one if:
+            if nsec3params is not None:
+                if len(nsec3params) > 1:

Maybe I'm missing something. But why does the dns plugin code use 
following all over the place:

         try:
             nsec3params = rrattrs['nsec3paramrecord']
         except KeyError:
             pass
         else:
             if nsec3params is not None:

instead of:

     nsec3params = rrattrs.get('nsec3paramrecord')
     if nsec3params is not None:

btw you use both patterns in the patch.

Patch #0061: ACK


Patch #0062:

3. Why are there the idnafsdbrec1 variables?

4. related to ^^:
./ipatests/test_xmlrpc/test_dns_plugin.py:199:33: E231 missing 
whitespace after ','


Patch #0063: LGTM
IDK if they work because I'm experiencing some weird issues with 
xmlrpc_tests in general.

-- 
Petr Vobornik