[Freeipa-devel] [PATCHES 202-222] Ipaplatform refactoring

[Petr Viktorin]

On 06/16/2014 02:53 PM, Tomas Babej wrote:
> On 06/10/2014 05:07 PM, Petr Viktorin wrote:
>> On 06/10/2014 10:13 AM, Tomas Babej wrote:

>>> On 06/06/2014 01:04 PM, Petr Viktorin wrote:
>>>> On 06/05/2014 03:14 PM, Petr Viktorin wrote:
>>>>> On 06/04/2014 11:42 AM, Tomas Babej wrote:
>>>>>> Hi,
>>>>>>
>>>>>> the following set of patches implements the ticket:
>>>>>>
>>>>>> https://fedorahosted.org/freeipa/ticket/4052
>>>>>>
>> [...]
>>>>>

0202: OK
0203: OK
0204: OK
0205: OK
0206: OK
0207: OK
(sorry for the conflict!)

0208: OK
0209: OK
0210: OK
0211: OK
0212: OK
0213: OK
0214: OK
0215: OK
0216: OK
0217: OK
0218: OK
0219: OK
0220: OK
0221: OK
0222: OK

modify_nsswitch_pam_stack and modify_pam_to_use_krb5 are missing the 
`self` argument.

Rebasing this all the time must be painful, so to avoid another review 
round-trip I've had Tomáš ACK the attached four-liner on IRC.

0223: OK


ACK to the above with my fix, but see more comments below.
Pushed to master: d868fc5566da547d2060ef4a42eb5a0d0e0a72d6



0224:

insert_ca_cert_into_systemwide_ca_store
remove_ca_cert_from_systemwide_ca_store
     typo: certificated

restore_pre_ipa_client_configuration
     mentions obsolete tasks



Additional:
Is tasks.get_svc_list_file necessary?


-- 
Petr³

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0588-Fix-self-argument-in-tasks.patch
Type: text/x-patch
Size: 1948 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140616/bea1e9fb/attachment.bin>