[Freeipa-devel] [PATCHES 202-222] Ipaplatform refactoring

[Tomas Babej]

On 06/18/2014 10:52 AM, Petr Viktorin wrote:
> On 06/17/2014 02:15 PM, Tomas Babej wrote:
>>
>> On 06/17/2014 12:03 PM, Timo Aaltonen wrote:
>>> On 17.06.2014 11:16, Martin Kosek wrote:
>
>> Attached is a new version of patch 226, and a new patch 228, which moves
>> the paths from installers to the paths module.
>
> In patch 226, there's another "certificated" typo in
> remove_ca_cert_from_systemwide_ca_store
>
>> I greped the repository, and I do not see many paths lurking around any
>> more, there are only some in the error messages (as these can't be
>> reliably replaced automatically, and will need some manual love).
>>
>> If you see any forgotten paths, which should be added to the module, let
>> me know.
>
>
> I see another duplicate:
>     SSS_KRB5_INCLUDE_D = "/var/lib/sss/pubconf/krb5.include.d"
>     SSSD_PUBCONF_KRB5_INCLUDE_D_DIR =
> "/var/lib/sss/pubconf/krb5.include.d/"
>
>
> Rather than using e.g.
>     filename = paths.VAR_KERBEROS_KRB5KDC_DIR + file
> It would be cleaner to use
>     filename = os.path.join(paths.VAR_KERBEROS_KRB5KDC_DIR, file)
>
>
Fixed all mentioned issues. I also attached a patch 230, which removes
the base Authconfig class.

-- 
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0230-ipaplatform-Drop-the-base-authconfig-class.patch
Type: text/x-patch
Size: 6053 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140619/8f0d7f59/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0228-3-ipaplatform-Move-paths-from-installers-to-paths-modu.patch
Type: text/x-patch
Size: 61141 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140619/8f0d7f59/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0226-3-ipaplatform-Document-the-platform-tasks-API.patch
Type: text/x-patch
Size: 4755 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140619/8f0d7f59/attachment-0002.bin>