[Freeipa-devel] [PATCH 0056] Add otptoken-sync command

Nathaniel McCallum npmccallum at redhat.com
Tue Jun 24 20:57:40 UTC 2014


On Tue, 2014-06-03 at 09:18 -0400, Nathaniel McCallum wrote:
> On Tue, 2014-06-03 at 10:27 +0200, Petr Vobornik wrote:
> > On 3.6.2014 05:08, Nathaniel McCallum wrote:
> > > This command calls the token sync HTTP POST call in the server providing
> > > the CLI interface to synchronization.
> > >
> > > https://fedorahosted.org/freeipa/ticket/4260
> > >
> > > This patch depends on my patch #0055.
> > >
> > 
> > Build fails on validation. You forgot to update API.txt and also the 
> > command misses __doc__.
> > 
> > (not a proper review)
> 
> Thanks, fixed.

Attached is a new revision which is rebased on master.

In addition it:

1. Moves user to a parameter and moves token to an argument. Doing it
this way both mirrors the existing otptoken APIs and sets us up for
future Kerberos based syncing where the username/password will be
optional.

2. Converts the token ID to a DN.

Nathaniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-npmccallum-0056.2-Add-otptoken-sync-command.patch
Type: text/x-patch
Size: 4384 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140624/a8beac8d/attachment.bin>


More information about the Freeipa-devel mailing list