[Freeipa-devel] [PATCH 0076] Fix incompatible DNS permission

[Petr Viktorin]

On 06/20/2014 03:28 PM, Martin Basti wrote:
> Patch attached.
>
> Ticket:https://fedorahosted.org/freeipa/ticket/4383

This works, just two comments:

To check if an entry exists, instead of calling
     api.Command['permission_show'](permission_name_rel)
you should call the more light-weight
     api.Object[permission].get_dn_if_exists(permission_name_rel)

And for translated messages, use:
     _('message about %(topic)s") % {...}
rather than:
     _('message about %(topic)s" % {...})
In other words, _() must be called on a literal string. Otherwise it 
couldn't be looked up in the translation database (or even picked up by 
gettext).


-- 
Petr³